Git Product home page Git Product logo

Comments (10)

ploeh avatar ploeh commented on August 27, 2024

Thank you for drawing my attention to this issue, which I wasn't aware of.

This is most likely connected to GitHub Pages' recent upgrade to Jekyll 3.

I'll investigate this particular issue when I have time, but I'm no Jekyll or Ruby expert, so if anyone reads this, and think they can help, I'd appreciate it.

from ploeh.github.com.

ploeh avatar ploeh commented on August 27, 2024

When I look at http://blog.ploeh.dk/rss.xml, the most recent article is linked like this:

<link>
http://blog.ploeh.dk/2016/02/12/types-properties-software-properties-for-the-advantage-state/
</link>

This URL seems to be perfectly reachable. It's not the URL you've reported, though.

The URL you've reported is present in the RSS feed, but in the <guid> element; you can't expect this value to be a URL, let alone a valid URL.

The same goes for http://blog.ploeh.dk/atom.xml. The link is provided in a <link> element:

<link rel="alternate"
      type="text/html"
      href="http://blog.ploeh.dk/2016/02/12/types-properties-software-properties-for-the-advantage-state/"/>

Again, the link you are reporting is the <id> field, which you should treat as an opaque identifier - not as a URL.

from ploeh.github.com.

FennNaten avatar FennNaten commented on August 27, 2024

Hum, you're right.
I'm using feedly to manage my subscriptions when on a browser. The subscription points to the right url, and the target xml is as you described it. However feedly seems to use the guid instead of the link, even for the link-sharing functionalities.
Seems like a bug on feedly side, not on your end, sorry for the disturbance, I should have checked the source directly instead of relying on what's provided on the interface.

from ploeh.github.com.

FennNaten avatar FennNaten commented on August 27, 2024

Before contacting feedly to fill a bug report, I checked the RSS spec (as it seems that feedly only uses the RSS file for this blog), and contrary to what I expected, it seems that depending on the interpretation of this spec feedly's behavior can be correct.
http://cyber.law.harvard.edu/rss/rss.html#ltguidgtSubelementOfLtitemgt

If the guid element has an attribute named "isPermaLink" with a value of true, the reader may assume that it is a permalink to the item.
isPermaLink is optional, its default value is true.

I didn't know that, and it feels odd, but it's consistent with atom specs which states that ids must be valid, stable, rfc3987 IRI.

Learning things everyday. ^^'

from ploeh.github.com.

ploeh avatar ploeh commented on August 27, 2024

Good research work 👍 I didn't know that.

It seems that the correct resolution to this issue would be to add the attribute isPermaLink="false" to the guid element. Do you agree?

from ploeh.github.com.

FennNaten avatar FennNaten commented on August 27, 2024

Hi,
I think this should do the trick, according to the spec, however it's still a bit of guesswork hoping that feedly follows it. ^^'
In fine, it depends mostly on what you want to express in your feed, adding this would clearly show that you don't guarantee this guid to be a valid link.

from ploeh.github.com.

ploeh avatar ploeh commented on August 27, 2024

OK, the change is now live. It may take a while before it propagates through all caches.

from ploeh.github.com.

FennNaten avatar FennNaten commented on August 27, 2024

Tested, I confirm that feedly now uses the data from the link tag and not anymore the data from the guid tag, for both display and social share.

from ploeh.github.com.

ploeh avatar ploeh commented on August 27, 2024

Sounds good. Thank you for providing feedback. Can we close this issue, then?

from ploeh.github.com.

FennNaten avatar FennNaten commented on August 27, 2024

Sure! Thanks for your time.

from ploeh.github.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.