Comments (5)
I see xfer is there? I see hangup is set to None.
Had to update my trunk to see changes. (Sorry)
from plivoframework.
I updated and I see it was added to the code base.
I still think there is a problem with it;
I had to manually add to the plivo/default.com
HANGUP_URL for it to work.
This is the wrong behavior.
If the plivo_answer_url is set from FS channel var then we should update the HANGUP_URL if the default one is not specified;
some cases;
NO HANGUP_URL specified
- Use Default Answer URL or plivo_answer_url channel variable
HANGUP_URL specified
2. Do not overwrite with FS channel variable
HANGUP_URL passed from FS
overides everything
I think this is done; but its not working in my test scenario
from plivoframework.
ok I have modified the resolution order for Answer and Hangup Urls in the last commit :
-
For Outbound Calls (calls make from REST Api with Call or BulkCalls) :
answer url resolution order :
- get plivo_transfer_url from channel var - get plivo_answer_url from channel var
hangup url is not set because it is handled by in rest api
-
For Inbound Calls :
answer url resolution order :
- get plivo_transfer_url from channel var - get plivo_answer_url from channel var - get default answer_url from config
hangup url resolution order :
- get plivo_hangup_url from channel var if found - get default_hangup_url from config if found - get plivo_answer_url from channel var if found - get default_answer_url from config if found
from plivoframework.
any feedback ?
from plivoframework.
Seems good. Although new bug as of today which I fixed not regarding this; I opened another comment.
from plivoframework.
Related Issues (20)
- SchedulePlay doesn't use delimiter
- Element "Number" can't call RTMP session HOT 2
- Redux: Issue with FS originate #48
- Timeout callback
- Documentation is missing HOT 4
- DTMF element does not exist
- Inbound call and hangup url
- Plivo Freeswitch installation script HOT 2
- outboundserver not fetching the action url with the given method parameter in GetDigits tag
- call hang when preforming tranasfer
- gevent problem on Debian Jessie (missing SSLv3) HOT 5
- How to test ?
- Plivo outgoing calls going to voicemail
- Send appropriate User Agent
- Getdigits not detecting the pressed digits randomly?
- List of companies uisng plivoframework HOT 1
- call HANGUP with NORMAL_CLEARING HOT 1
- lockingSwitchOutError: Impossible to call blocking function in the event loop callback HOT 2
- Silence_threshold is too high
- Option to this project HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plivoframework.