Git Product home page Git Product logo

Comments (9)

mike-plivo avatar mike-plivo commented on July 29, 2024

Ok here is what I have added for Record Element :

RecordingFileFormat : mp3 or wav
RecordingFilePath : path of directory where is recorded file
RecordingFilename : name of recorded file without directory path
RecordingFullFilePath : full path of record file (directory + filename)
RecordingDuration : length of recorded file in ms NOTE that if bothLegs is used, its always "-1"
because recording is in progress in background.
Digits : digit terminator NOTE that if bothLegs is used, its always "" (empty) for the same reason

It's available in last commit, I'm waiting for your feedback on this new feature =)

from plivoframework.

chmac avatar chmac commented on July 29, 2024

Awesome. :-)

Is RecordingDuration in microseconds or in seconds? I think in seconds is possibly more friendly, that's what Twilio return anyway.

Does this also add the action and method parameters to the Record verb?

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

yes :)

I just committed another thing :
when call hangup during Record the http request is now handled too.

For RecordingDuration if you set it to seconds you will lose the precision of exact duration =)

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

Any feedback ?

from plivoframework.

chmac avatar chmac commented on July 29, 2024

I'm not sure how to update plivo to the latest code, and I'm not using this specific feature so I haven't got a use case to test it at the moment. If you can point me to instructions on updating plivo, I'm happy to try some manual tests and post back how I get on.

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

yes sure :)

To update to the last revision :

cd /path/to/your/plivo/install
cd src/plivo
git pull

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

I renamed RecordingFullFilePath to RecordFile like in Rest API .

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

renamed filename to fileName for Record element
renamed RecordFilename to RecordFileName for Conference element
renamed RecordingFilename to RecordingFileName

all tested => works

IMPORTANT :
The config file in plivo has changed so I recommend you remove your current plivo install and reinstall it from scratch
(not FS only plivo)
Note that now, hangup http request is handled in plivo-rest for both incoming and outgoing calls.

from plivoframework.

mike-plivo avatar mike-plivo commented on July 29, 2024

closing => tested

from plivoframework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.