Git Product home page Git Product logo

Comments (11)

featheredtoast avatar featheredtoast commented on July 30, 2024

Huh, that was working the last time I worked on it; Not sure what broke - I'll have a quick look soon, sorry about that!

dev-target is definitely on purpose. There are actually some really nasty and difficult to trace refresh issues when compiling with cljc files with cljs under a clj classpath. tldr, cljs compilation copies the sources over for use in source maps, including the cljc files. When you run a vanilla clojure refresh, it also picks up and attempts to reload the copied cljc files as well, resulting in some pretty broken repls.

That said, if you aren't using cljc you should be fine with just using resources as a compilation path.

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

btw, localhost:3449 is a separate port that is serving figwheel; not your app -- you should be able to ignore that entirely.
Your app is served on http://localhost:10555

Mind confirming that this is the case?

from chestnut.

TimoFreiberg avatar TimoFreiberg commented on July 30, 2024

Will do!

from chestnut.

TimoFreiberg avatar TimoFreiberg commented on July 30, 2024

Looks like I missed the Started test-app on http://localhost:10555 there.
I still get an error on localhost:10555, but it seems like it's a completely different one:

Error: Error in component :app-root in system function (__meta,__extmap,__hash){
this.__meta = __meta;
this.__extmap = __extmap;
this.__hash = __hash;
this.cljs$lang$protocol_mask$partition0$ = 2229667594;
this.cljs$lang$protocol_mask$partition1$ = 139264;
} calling #'com.stuartsierra.component/start
core.cljs:11123:10

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

Alright, so this is problematic, but this seems to be an issue with om upstream, as React.createClass has been deprecated/removed.

Quickly adding dependencies in project.clj for react 15.x allows this to compile again:

[cljsjs/react "15.0.0-0"]
[cljsjs/react-dom "15.0.0-0"]

This is om specific and should not affect other view layers like reagent or rum.

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

Alternatively, I can also confirm that om beta-1 also works:
[org.omcljs/om "1.0.0-beta1"]

from chestnut.

plexus avatar plexus commented on July 30, 2024

Looking at omcljs/om#899 it seems this is an issue with om.core ("classic" om), nobody has put in the work so far to make it compatible with React 16. There's a fork by @danielsz, but I don't see a PR to bring that back upstream.

We could pin React to React 15 when using classic Om, but maybe it's time to drop support for it altogether, if you're starting a new app I don't think it still makes sense to use classic Om. I would also prefer to switch to Reagent as the default. I think it's clear by now that in terms of mindshare and beginner friendliness Reagent has won.

from chestnut.

TimoFreiberg avatar TimoFreiberg commented on July 30, 2024

I would not mind either of those changes, but since I'm a total Clojurescript beginner I don't have a well-founded opinion.

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

reagent as a sane default makes a whole lot of sense. I'd support making that the default and drop om classic.

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

An update on this -- I'm making the decision to drop om, and have reagent be default in the latest release.

from chestnut.

featheredtoast avatar featheredtoast commented on July 30, 2024

Reagent is now the default rendering via #241

from chestnut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.