Comments (4)
Done in branch 1.4.x for many cases (but unfortunately not for all).
from play1.
While it is a good philosophy to not swallow exceptions, the code now no longer executes the original author's intent.
The code is meant to identify whether the current start tag is a GroovyInlineTag, i.e., an #{if...} #{else...} or #{list...}
If it is not, then the code should swallow the exception and continue to the next section to note other characteristics of the tag.
You should probably put back the original exception handler of:
// do nothing here
And add more code comments so that future maintainers have a clearer understanding of what's happening in this method.
from play1.
@selangley I agree, I enabled too much logging. I am going to remove some of them.
from play1.
@asolntsev It is the problem I talked you about, I will try to keep your change and avoiding the exception: will be handle in #1009
from play1.
Related Issues (20)
- about play 1.7.1 log problem HOT 2
- Play 1.7 WS problem (header too large) HOT 2
- PlayStatusPlugin method computeApplicationStatus throws ClassCastException HOT 1
- "play auto-test" can return a exit code zero when the tests don't run HOT 2
- please add log4j2 config to a sample project HOT 1
- enable "Discussions" for play1 github project HOT 2
- Play Framework 1.x with OpenID Connect HOT 4
- Removed support for python 2.x in github action
- IO / play precompile broken HOT 5
- dependency resolution breaks precompiled
- hibernate_sequence doesnt exists. HOT 1
- Play build-module failes¨s
- Play build-module fails HOT 1
- The imp module was removed from python 3.12 HOT 5
- Support for Java 21 HOT 4
- Regression: "play auto-test --timeout" broke in python3 upgrade
- Python AttributeError: module 'time' has no attribute 'clock' HOT 1
- Upgrade to Hibernate 5.6 -> 6.4 HOT 2
- Play Framework Module Configuration Issue: Detection of Plugins Absent in addModule Method
- Improved documentation for transaction handling in jobs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from play1.