Git Product home page Git Product logo

Comments (4)

asolntsev avatar asolntsev commented on July 23, 2024

Done in branch 1.4.x for many cases (but unfortunately not for all).

from play1.

selangley avatar selangley commented on July 23, 2024

While it is a good philosophy to not swallow exceptions, the code now no longer executes the original author's intent.

The code is meant to identify whether the current start tag is a GroovyInlineTag, i.e., an #{if...} #{else...} or #{list...}

If it is not, then the code should swallow the exception and continue to the next section to note other characteristics of the tag.

You should probably put back the original exception handler of:

// do nothing here

And add more code comments so that future maintainers have a clearer understanding of what's happening in this method.

from play1.

asolntsev avatar asolntsev commented on July 23, 2024

@selangley I agree, I enabled too much logging. I am going to remove some of them.

from play1.

xael-fry avatar xael-fry commented on July 23, 2024

@asolntsev It is the problem I talked you about, I will try to keep your change and avoiding the exception: will be handle in #1009

from play1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.