Comments (6)
angryziber
commented on July 22, 2024
Do you have any examples of which code breaks?
We found that without this change, sometimes you could #{set} something and then use the value with just ${}
from play1.
xael-fry
commented on July 22, 2024
@angryziber As I said in #1039, I am doing a PR with tests for that.
Yes this is the goal of set, so you mean that with your change with cannot do it anymore.
from play1.
angryziber
commented on July 22, 2024
I thought the goal of set is to influence get with the same name? In most
cases they lived in separate namespaces, afaik. But I found one case, where
the set value was accessible via ${} before, but not anymore.
…On Wed, 28 Dec 2016, 02:50 Alexandre Chatiron, ***@***.***> wrote:
@angryziber <https://github.com/angryziber> As I said in #1039
<#1039>, I am doing a PR with
tests for that.
Yes this is the goal of set, so you mean that with your change with cannot
do it anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1067 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA11YJ6VWC3uhQgDKJxOQ-UYBivNuvzQks5rMbJogaJpZM4LV-vH>
.
from play1.
xael-fry
commented on July 22, 2024
Yes I could be used by Get, but as nothing block to used it another way, we cannot block now a behavior that was accepted before, or it will affect users projects, or we should do it in a major revision.
But what do you mean by But I found one case, where the set value was accessible via ${} before, but not anymore., in your project, in play/examples?
from play1.
angryziber
commented on July 22, 2024
In my project.
But do you say that that was an intended behaviour, #{set} and then ${}
instead of #{get}?
…On Thu, 29 Dec 2016, 02:45 Alexandre Chatiron, ***@***.***> wrote:
So we cannot block now a behavior that was accepted before, or it will
affect users projects.
But what do you mean by But I found one case, where the set value was
accessible via ${} before, but not anymore., in your project, in
play/examples?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1067 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA11YBHeno9jl4M96Yy0oWbed0-ORN-Qks5rMwKwgaJpZM4LV-vH>
.
from play1.
xael-fry
commented on July 22, 2024
No I just say that the initial behavior was to used #{set} /#{get} but as we allowed to used ${} in the past, I am not sure we can remove this behavior in the minor release
from play1.
Related Issues (20)
- Upgrade com.ning:async-http-client to org.asynchttpclient:async-http-client HOT 5
- Can not create custom datasource config HOT 2
- NullPointer in JPABase.cascadeOrphans() caused by unused lines HOT 1
- about play 1.7.1 log problem HOT 2
- Play 1.7 WS problem (header too large) HOT 2
- PlayStatusPlugin method computeApplicationStatus throws ClassCastException HOT 1
- "play auto-test" can return a exit code zero when the tests don't run HOT 2
- please add log4j2 config to a sample project HOT 1
- enable "Discussions" for play1 github project HOT 2
- Play Framework 1.x with OpenID Connect HOT 4
- Removed support for python 2.x in github action
- IO / play precompile broken HOT 5
- dependency resolution breaks precompiled
- hibernate_sequence doesnt exists. HOT 1
- Play build-module failes¨s
- Play build-module fails HOT 1
- The imp module was removed from python 3.12 HOT 5
- Support for Java 21 HOT 4
- Regression: "play auto-test --timeout" broke in python3 upgrade
- Python AttributeError: module 'time' has no attribute 'clock' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from play1.