Comments (13)
Okay! I'll add this to my list for when I have time & focus, otherwise happy to accept a PR that implements this feature.
from togeojson.
oh, not sure how I came up with heartRates
tbh 🙈
I'll change it to heart
if Tom agrees :)
from togeojson.
Yep, whoops - should've caught that. Let's change it.
from togeojson.
That is the case. There's nothing more official than a repository, because there's neither the means nor the need to get an official stamp (OGC does standards, but mostly for the military, and they make mostly bad standards, IETF makes good standards but it takes months & a corporate sponsor). If anyone were to carry the defacto spec forward, it would be an entity like Strava or Mapbox, but it's really up to them.
Both coordTimes and coordProperties work as representations, and are probably the right way to represent that kind of data. We've had some threads about them, and no better alternative floated to the surface. toGeoJSON uses coordTimes mostly just because of legacy and because it'll be a major version bump to switch to coordProperties and nobody's asked or proposed a PR - though I wouldn't be opposed to one.
from togeojson.
Thanks. In that case, I'd like to convert this to a request for that change.
To reiterate the specific request: I'm asking to move the current property [feature].properties.coordTimes
to [feature].properties.coordinateProperties.times
, per the extension draft by Mapbox. It has been adopted by at least one other product.
I think this change will also allow for more structure in supporting additional waypoint properties beyond times
for each set of coordinates. For example: names
, descriptions
, types
, heart
, etc.
(To be clear, I'm not recommending those specific strings as keys for the additional waypoint properties, rather I'm just illustrating the idea.)
from togeojson.
I could make a PR for this... but I'm not sure how this should work: would the heartRate
also move to coordinateProperties
or just the times
property? to be honest I'm not sure what the advantage is, if only times
moves there.
from togeojson.
Yep, the idea is that heartRates
would move to coordinateProperties.heart
, and times
would move to coordinateProperties.times
.
The current representation and the geojson-coordinate-properties representation are equivalent in power and roughly the same in terms of efficiency/size/etc. The only advantage is that geojson-coordinate-properties is more precisely explained by a spec and there may be other implementations that adopt the geojson-coordinate-properties style.
from togeojson.
sounds good, I'll have a look next weekend to see if I can make a PR :)
from togeojson.
we moved the heartRates
and times
to coordinateProperties
@jsejcksn. We can probably close this?
from togeojson.
Thanks for creating the PR that was merged. I am wondering about its conformance to the proposed extension I linked to in the original message. In the proposal, it states:
Members of the
coordinateProperties
property can have any name, but semantics of two names are defined:
times
...heart
...
In your PR, you implemented heart
as heartRates
. Was there a reason that you used that name instead of the one defined in the extension proposal?
from togeojson.
oh, not sure how I came up with
heartRates
tbh 🙈
I'll change it toheart
if Tom agrees :)
No worries. 😄
@tmcw Thoughts?
from togeojson.
I'll make a PR next week.
from togeojson.
Thanks @RalucaNicola
from togeojson.
Related Issues (20)
- gpx() and kml() types aren't symmetric HOT 2
- This should complain if the input is not valid XML or valid KML HOT 1
- Unable to use ESM import HOT 5
- Translate TCX courses to folders
- Translate GPX trk elements to Folders
- Keep KML placemarks with missing coordinates HOT 4
- Folder data HOT 1
- Remove swc dep?
- Add support for LinearRing outside Polygon HOT 1
- GPX conversion adds "s" character to extension names HOT 1
- TS7016: Could not find a declaration file
- GPX metadataType HOT 2
- KML Bounds Not Parsed HOT 3
- Unexpected link to online shop in dist/lib HOT 1
- skipEmpty option for KML HOT 1
- KMZ overlay with rotation not working correctly HOT 2
- KMZ overlays not aligning same as seen in Google Earth HOT 3
- gpxx extensions without namespace HOT 1
- Reason for not mapping all found TrackPointExtensions, and only keeping one? HOT 2
- Github sponsoring HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from togeojson.