[storage] Adding base storage tests about pkgcloud HOT 10 CLOSED

@cronopio ping.

from pkgcloud.

@fearphage That's a good question. I think the best approach is to breakup the tests in test/common into more granular suites that we can compose for different services.

from pkgcloud.

Then we can have the test runner only run your tests for Rackspace

from pkgcloud.

The problem I see with that is that someone now has to maintain configuration for tests. That's suboptimal.

When X implements feature Y for Amazon, part of that persons work is to update the config to allow that feature to be tested. That seems like a poor experience but I'm not sure how to get around it.

It would be nice to have each batch in storage/base-test be an individual file. For the time being, we can get by with the following:

if (providerName == 'rackspace') {
  suite.addBatch(newHotness);
}

Then when someone implements the hotness, they'll have to add their service to the list of things that should run this test.

from pkgcloud.

@fearphage What do you think about the style used here:

https://github.com/nodejitsu/pkgcloud/blob/openstack-tests/test/common/compute/server-test.js#L443-L475

You can add test and enable/disable for specific provider. At least is a temporal solution until the rewrote of common test suite.

from pkgcloud.

I would like to point out how important common tests are — they are the biggest feature in pkgcloud

The optional newHotness are ok, but should be considered suboptimal. Having a consistent api is the most important thing imo

from pkgcloud.

For reference, newHotness is just things that haven't been implemented in other APIs yet although it is on the list. That hotness in my case is batch downloads -- getFiles('containerName', true, callback).

And thanks for that @cronopio, that's the route I took for now.

from pkgcloud.

Is this issue still alive?

from pkgcloud.

Hmmm, looked for this code and I think this is it.

https://github.com/fearphage/pkgcloud/compare/df6885edb555279aef61b0ffe282b5c3cf034bb9...7216cfe6e5137aef7560602c4c10f6282c7c5386?w=1

I haven't touched it since we stopped talking as it shows.

from pkgcloud.

Long story short: feel free to add tests in tests/rackspace/storage.

from pkgcloud.