.gitignore test/fixtures/testkey* breaks npm installed pkgcloud about pkgcloud HOT 7 CLOSED

I been thinking this in a while. Im not sure if 2193228 could expose a security gap for you I guess no, so I would go more for a fake testkey like

-----BEGIN RSA PRIVATE KEY-----
SoMeThIngFuNhErEaNdOthErsRaNdoMsChArAtEres
-----END RSA PRIVATE KEY-----

ssh-rsa MoArRandOmChArAcTeReSHeRe  [email protected]

In that case we should select different files when nock is disabled and point the users to create their own key when want to do a "live" run tests like we do on authentication configs.

from pkgcloud.

Excellent suggestion. I will give the fake testkey files a try to make sure they do not break any tests on all the providers. I will also update azure to use fake management certificates (if possible). We already select different config files when nock is turned off and errors are thrown when the files are not found. The user is already required to add a config file in test/configs for each provider when nock is off. These .json config files are ignored with .gitignore. When nock is on, we look in test/configs/mock for the provider config files.

from pkgcloud.

Yeah, thats what I mean, do the same.

@stammen you are doing an awesome work.

from pkgcloud.

I submitted a pull request with the testkeys now using the dummy data. I used SoMeThIngFuNhErEaNdOthErsRaNdoMsChArAtEres encoded to base64 in all of the files.

from pkgcloud.

Thanks @stammen, can you try now with the HEAD of master at bc154ff if your reproducible test case is solved, for confirm please.

from pkgcloud.

All tests pass in reproducible test case on windows and mac using HEAD of master at bc154ff.

from pkgcloud.

awesome!

from pkgcloud.