Debug output about pkgcloud HOT 5 CLOSED

The lack of logging has been giving me a fair amount of grief, so I've been toying with something like yay:

var Client = exports.Client = function (options) {
  events.EventEmitter2.call(this, { delimiter: '::', wildcard: true });
  this.config = options || {};

  // Setup logging
  this.log = options.log || function() {};
  this.on('log', this.log);
};

Elsewhere simply:

this.emit('log', 'verbose', 'Starting Request', requestPayload);

What do you think? I'm happy to get started on something because it would greatly assist when debugging and developing new features. I want something I can integrate with winston, but doesn't actually require any specific logging framework.

from pkgcloud.

I would appreciate the ability to log out to winston from the library. +1

from pkgcloud.

@kenperkins That could work, really though all we need to do is emit the options we pass to request each time as in nodejitsu-api: https://github.com/nodejitsu/nodejitsu-api/blob/master/node.js/lib/client/client.js#L187

from pkgcloud.

Do you leave it up to the caller to implement client.on('xxx') ? or should it be passed into the client as an option?

Is everything just a debug message? do we have any need of different levels of verbosity within pkgcloud proper?

For example, we could do this.emit('log::debug', message, opts) or we could do this.emit('debug::request', opts) but that could make multiple levels complicated.

from pkgcloud.

I've implemented a minimal amount of logging in core/client and in a few places in the rackspace/openstack providers.

example:

var client = pkgcloud.providers.rackspace.compute.createClient({ ... });

client.on('log::*', function(message, meta) {
    // use your logging info here
});

Was introduced with 41e96d4

from pkgcloud.