cbtree/Tree depends on ForestStoreModel and TreeStoreModel about cbtree HOT 5 CLOSED

I'm not sure I completely follow you line of thought. Technically I could remove both ForestStoreModel and TreeStoreModel but in that case _store2model will have to go too as it is the only method referring to ForestStoreModel. As a matter of fact, _store2model was only added to pass some of the default dijit tree unit tests. The underlying dijit tree states '_store2model is for v1.0 dijit tree backward compatibility only and will be removed from the dijit tree 2.0'.

-----Original Message-----
From: Vladimir Elistratov [mailto:[email protected]]
Sent: Monday, April 23, 2012 4:10 AM
To: pjekel
Subject: [cbtree] cbtree/Tree depends on ForestStoreModel and TreeStoreModel (#11)

I don't use either of them.
A larger problem is that I am getting empty dojo.js for my library build. Once I remove ForestStoreModel and TreeStoreModel from the cbtree/Tree dependencies, I am getting a working build.

If you would prefer to keep them and _store2model, I'd suggest to create cbtree/BaseTree and move all stuff there out of cbtree/Tree except _store2model

Reply to this email directly or view it on GitHub:
#11

from cbtree.

One more thing, with regards to your build I noticed the problem I reported earlier where an error is generated like: 'x is not a constructor' seems to be back. However, if you build the library with profile setting: "optimize:'shrinksafe'" and "layerOptimize:'shrinksafe'" instead of the Google 'closure' compiler the problem is fixed and everything works as expected.

-----Original Message-----
From: Vladimir Elistratov [mailto:[email protected]]
Sent: Monday, April 23, 2012 4:10 AM
To: pjekel
Subject: [cbtree] cbtree/Tree depends on ForestStoreModel and TreeStoreModel (#11)

I don't use either of them.
A larger problem is that I am getting empty dojo.js for my library build. Once I remove ForestStoreModel and TreeStoreModel from the cbtree/Tree dependencies, I am getting a working build.

If you would prefer to keep them and _store2model, I'd suggest to create cbtree/BaseTree and move all stuff there out of cbtree/Tree except _store2model

Reply to this email directly or view it on GitHub:
#11

from cbtree.

If you agree to get rid of _store2model, then just do it.

If not, then I suggest to have cbtree/BaseTree and cbtree/Tree. Cbtree/Tree is inherited from cbtree/BaseTree. Cbtree/Tree contains only one function: _store2model. Cbtree/BaseTree doesn't depend on ForestStoreModel and TreeStoreModel, but cbtree/Tree does depend on them

Regarding the build, I mean not the build for cbtree itself, but the build for my own stuff (that includes cbtree)

from cbtree.

I will remove _store2model, it's dependencies, and update the unit test, I don't think anybody is using dojo 1.0 anyway. That still doesn't explain why you end up with an empty dojo as the dijit tree, from which cbtree inherites, defines its own dependencies on its TreeStoreModel and ForestStoreModel.

-----Original Message-----
From: Vladimir Elistratov [mailto:[email protected]]
Sent: Monday, April 23, 2012 8:33 AM
To: pjekel
Subject: Re: [cbtree] cbtree/Tree depends on ForestStoreModel and TreeStoreModel (#11)

If you agree to get rid of _store2model, then just do it.

If not, then I suggest to have cbtree/BaseTree and cbtree/Tree. Cbtree/Tree is inherited from cbtree/BaseTree. Cbtree/Tree contains only one function: _store2model. Cbtree/BaseTree doesn't depend on ForestStoreModel and TreeStoreModel, but cbtree/Tree does depend on them

Regarding the build, I mean not the build for cbtree itself, but the build for my own stuff (that includes cbtree)

Reply to this email directly or view it on GitHub:
#11 (comment)

from cbtree.

Found the problem with my build: just a comma in the line 193 of cbtree/models/TreeStoreModel.js
Please remove it.

However I'd still vote for removal of _store2model

from cbtree.