Bug: ClassRef is not a constructor about pixijs HOT 3 CLOSED

I cannot reproduce: https://jsfiddle.net/bigtimebuddy/pjvrebs8/

Please provide more information or an example that minimally reproduces the problem.

from pixijs.

I conducted a new review and realized that when I add this code to my project, this issue arises. I need the functions with the same name.

Array.prototype.remove = function (item) { return this.splice(this.indexOf(item), 1) }
Array.prototype.insert = function (index) { this.splice.apply(this, [index, 0].concat(Array.prototype.slice.call(arguments, 1))); return this; }

from pixijs.

In general, adding prototype methods to global objects is not a good practice. It can lead to issues such as this, where we are doing a for-loop and it picks up these methods as enumerable. We see this sometimes with Object.prototype method because we often enumerate through the keys. The best solution is to create utility methods (e.g., ArrayUtils.remove(arr, item)). If you are going to add prototype chain methods, make sure they are not enumerable like this:

Object.defineProperties(Array.prototype, {
  remove: {
    enumerable: false,
    get(item) {
      return this.splice(this.indexOf(item), 1);
    }
  }
});

from pixijs.