Git Product home page Git Product logo

Comments (3)

mhluska avatar mhluska commented on May 27, 2024

If I replace, expect { 1000.times { subject.update_transactions_for(payment) } }.to perform_under(50).ms with expect { 1000.times { 'a' + 'b' } }.to perform_under(50).ms, it passes.

from rspec-benchmark.

mhluska avatar mhluska commented on May 27, 2024

This seems to be related to an external request being made. Once I added VCR, things worked fine.

from rspec-benchmark.

piotrmurach avatar piotrmurach commented on May 27, 2024

Hi Maros,

Thank you for using this gem! 🙏

rspec-benchmark only adds assertions which do not handle any IO operations per say.

In your specific case, I would suggest changing your example to:

expect { 
  subject.update_transactions_for(payment)
}.to perform_under(50).ms.sample(1000).times

This will provide a benefit of calculating an average run of the expectation and more stable results. Otherwise you're missing out on the benefits of using the expectation.

from rspec-benchmark.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.