Comments (5)
I see (or hope) not much re-architing
required here. sctp.Stream is already looks like net.Conn. We have two goroutines: writeLoop and readLoop, which wouldn't change. Read operation is already blocking, so it is Stream.WriteSCTP() (<-- I'd remove this method btw..) and underlying call into Association needs to be modified. I'd say we can just use Association's mutex to block the write operation (Association.sendPayloadData()). A challenge I can see from top of my head is because we have many streams competing over the shared Association, we'd need to figure out how to control the deadlines (e.g. SetDeadline, SetWriteDeadline). We'd need a small/short-lived timer routine for each blocking call...
This is my quick thought (I may be wrong). I think it is good idea for you to just go ahead try it out ;)
from sctp.
I'll give it a go once some of my paid work lets up :D
from sctp.
Also, for what it's worth, I don't think we're in any rush here, so no pressure to respond ASAP to this.
from sctp.
I'd recommend to focus on just blocking writes
for v2.
I am aware there are other desired API change such as Listen, Dial (to align with the standard SCTP API) but I think these are "nice to have" features imo and we can do it later. Also, yes RACK/TLP does not require API change.
Many users have been suffering from the async write and the blocking write is the most wanted feature atm. The streamlined goal with v2 make it more achievable to put it into pion/webrtc v4. (getting rid of pendingQueue out of the way for the future enhancement is also nice)
from sctp.
That's fine with me. Do you have any vision for what you'd re-architect to achieve blocking writes? I could "just" go down a proof of concept route to achieve and see what changes fall out. What do you think?
from sctp.
Related Issues (20)
- panic in Association.handleCookieEcho HOT 1
- What is the difference with Linux SCTP? HOT 2
- Changing initialRecvBufSize causes datachannel to hang
- Dependency Dashboard
- SACK chunks followed by other chunks are incorrectly handled. HOT 2
- Datachannels have a great latency for poor network HOT 9
- SCTP throughput ~8x slower than TCP when the connection has latency HOT 15
- User Initiated Abort (cause code: 12) not handled HOT 3
- Remove the pending buffer after the data channel call close() by either side. HOT 12
- SCTP Streams have no SetReadDeadline
- Race in TestStreamClose introduced by the previous merge
- Potential regression by a commit c0159aa in causing `TestAssociation_Shutdown` to fail HOT 5
- Expose error definitions HOT 6
- SCTP support capabilities HOT 1
- Document planned / implemented RFCs in README
- Flaky tests and/or goroutine leaks HOT 8
- Panic occured on one way data transmission through Client to Client stream
- sctp.Read sometimes returns DeadlineExceededError on past cancelled deadlines HOT 1
- No reliable way to be notified of a Stream buffer becoming empty HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sctp.