Comments (13)
We have already support version. https://github.com/pingcap/tidb/blob/master/util/printer/printer.go#L23
from tidb.
That's weird. Why put the version in the util package? From the structure it's not make sense.
from tidb.
We may use it in interpreter. MySQL protocol layer. Or HBase engine.
Put to util package, so we keep it DRY.
from tidb.
You mean you will use the version in many other packages? Then the version is out of control. ๐ธ
from tidb.
WOW, User could pass version information to those variables :)
from tidb.
@ngaut Well... You can make then read-only.
from tidb.
It's read only after assignment.
from tidb.
any updates? @ngaut
from tidb.
from tidb.
I have no idea on the version now. AFAIK https://github.com/pingcap/tidb/blob/master/util/printer/printer.go#L23 looks not good enough.
from tidb.
+1
Need something like Version()
around here, and it should return semantic version, so app can check it in case a bug was introduced in older version but fixed in newer one.
from tidb.
the version number is useful to version control.
Now I find that if tidb code updated, the old goleveldb data directory can't load.
So I need lock a version to make sure to develop and compile.
from tidb.
Currently TiDB is evolving extremely fast. The version information is generated automatically by makefile:
LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=$(shell date -u '+%Y-%m-%d %I:%M:%S')"
LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev-parse HEAD)"
Does that sound ok? @fuxiaohei
from tidb.
Related Issues (20)
- unstable test TestJoinSystemTableContainsView HOT 2
- Add support to get region from pd in the same data center
- INFORMATION_SCHEMA.TIFLASH_REPLICA data become lower case HOT 1
- all values โโof the TABLE_SCHEMA column of INFORMATION_SCHEMA.TIFLASH_REPLICA are converted to lowercase HOT 3
- The `connection count` metrics in TiDB after v7.5 should add `resouce_group` in legendFormat
- Can create global index with partition columns HOT 1
- Commit succeeded while the schema was changed during the execution of transaction
- PR#55306 may caused 8.1% performance regression in benchmarksql HOT 7
- KV Requests is sometimes not well batched when performing uniqueness checks
- br: support routine backup data validation
- UPDATE statement is not blocked by INSERT statement that inserts duplicate row HOT 1
- The mem_buffer_bytes field in the cluster_tidb_trx table is not accurately measured
- br: enhance br observability
- The metrics_tables table is missing the tidb_server_tokens metric
- Fail to analyze table after creating index
- Fail to analyze table after creating index
- Can I get the original text of a parser node? HOT 4
- ddl: recover table shouldn't change table info in cache HOT 2
- flaky TestRenameTableAutoIDs, report Lock wait timeout exceeded; try restarting transaction
- Add "Global" to SHOW INDEXES output
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidb.