Comments (1)
The problem should still exist on the master version.
tidb-tools/sync_diff_inspector/utils/pd.go
Lines 173 to 178 in 4572996
In our example, the customized version string only has 2 components ("-v6.1"), which does not match the required regexp
so tidbVersionRegex.FindString(versionStr)
will return an empty slice and taking [1:]
will crash the program.
Since this function is dealing with GC Safepoint with the PD API, it should ask PD for the version rather than TiDB. Or simply run UpdateServiceGCSafePoint
directly and fallback to "unsupported" once we get codes.Unimplemented
.
from tidb-tools.
Related Issues (20)
- sync-diff-inspector: use UNHEX for BINARY and VARBINARY types HOT 1
- *: bump tidb version
- diff: collation is applied incorrectly in ORDER BY when the primary key is composite HOT 1
- diff: collation should not be applied on non-string columns HOT 1
- ci failed: tls version mismatch
- Add more ddl event type to binlog filter package.
- please provide the table name when compare failed HOT 1
- Update TiDB Dependency
- binlog filter type invalid
- sync-diff-inspector: failed to initialize diff process since failed to parse SEQUENCE related table info
- Tiflow version is too low
- sync-diff-inspector: Description for -T is incorrect
- sync-diff-inspector: Startup error isn't helpful
- sync-diff-inspector: Compatibility with MySQL 8.4.0
- sync-diff-inspector: double quoting of table names HOT 1
- sync-diff-inspector: Leaves temporary trash directory around
- sync-diff-inspector: Confusing version output
- sync-diff-inspector: Doesn't check check constraints
- sync-diff-inspector: Failure on invisible column HOT 1
- Consider using TIDB_ROW_CHECKSUM() instead of CRC32
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidb-tools.