Option to save and retrieve Cookies as dicts instead of strings about instagram_private_api HOT 7 CLOSED

Doesn't pickle.dumps return a string? https://docs.python.org/2/library/pickle.html#pickle.dumps

I haven't had any problems saving the pickled string to a json file. I even wrote an example here https://github.com/ping/instagram_private_api/blob/master/examples/savesettings_logincallback.py based off how I save my settings. Does that not work for you?

from instagram_private_api.

pickle.dumps always returns bytes, the difference is that in Python 2, bytes is also str and gets automagically handled by the interpreter. In Python 3 with your example you get this instead:

TypeError: Object of type 'bytes' is not JSON serializable

from instagram_private_api.

Thanks for the catch. Please submit your changes in a PR and I'll get it merged.

from instagram_private_api.

It's actually possible to solve my original issue by just adding a .decode("utf-8") here.

I still think letting cookies be saved and restored as dicts is a useful feature, but it's not absolutely necessary to solve this problem.

from instagram_private_api.

Does that work for you?

I gave it a quick test but got
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte

With Py3.5.1

from instagram_private_api.

edit: Ah. I hadn't noticed 1de421a This works better now.

from instagram_private_api.

I'm going to keep refining and testing a CookieJar that accepts both dicts and str|bytes, but until then I'm closing this PR as the new changes are sufficient for saving to JSON.

from instagram_private_api.