Git Product home page Git Product logo

Comments (5)

HugoGranstrom avatar HugoGranstrom commented on June 8, 2024 1

That does sound like a good solution to me :) Then it's very obvious which flags are passed as well, now you have to dig in the nimiBook source code to find them

from nimibook.

pietroppeter avatar pietroppeter commented on June 8, 2024
  • locally you should be able to have full control on how to compile a single file using directly nim r and the args you want (you might need to dump the json first)
  • in general I think we should have the possibility to reset build default arguments (either with a new command or with a special option) and pass new ones.
  • ideally you might want to have a mechanism where override/customize arguments for each specific file/folder you build
  • incidentally looking at the default list of arguments I am wondering if -f is a good default argument

from nimibook.

HugoGranstrom avatar HugoGranstrom commented on June 8, 2024

locally you should be able to have full control on how to compile a single file using directly nim r and the args you want

This is exactly what I want to avoid actually, because of reproducibility. The other day we got an error on the CI but we had problems replicating it locally. If we could have seen the debug error messages directly in the CI it would have saved us much time.

in general I think we should have the possibility to reset build default arguments (either with a new command or with a special option) and pass new ones. ideally you might want to have a mechanism where override/customize arguments for each specific file/folder you build.

Agreed! Some simple files probably take more time to compile with release than they take to run with debug, so using debug could probably speed up things if done for those files.

incidentally looking at the default list of arguments I am wondering if -f is a good default argument

That does indeed sound very wasteful of time, I can't remember the rationale for introducing it in the first case 🤔 Feels like it had something to do with CI somehow 🤣

from nimibook.

pietroppeter avatar pietroppeter commented on June 8, 2024

one option would be to remove all default arguments and pass all additional arguments received (so that we do not have to think of an option name to reset default arguments). In particular to reproduce current build one would call nbook build -d:release -f --verbosity:0 --hints:off.

from nimibook.

pietroppeter avatar pietroppeter commented on June 8, 2024

fixed in #50

from nimibook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.