Git Product home page Git Product logo

Comments (2)

pierrec avatar pierrec commented on May 27, 2024

Hello,

Thank you for your analysis. The fix for #43 was real although the bug no longer reproduces since changes were made in handling uncompressible data. It should still be applied.

Could you please modify your pull request as follow:

  • add test and benchmark corresponding to your analysis and so to be able to spot regressions in future commits
  • check for the zdata capacity to be of bSize instead of 2xbSize

Thanks!

from lz4.

skidder avatar skidder commented on May 27, 2024

I'm still having a hard time understanding how this code is supposed to work. I've disabled use of lz4 as a way around this issue, so it's no longer urgent for me, but I'm interested in finding a solution.

from lz4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.