Random marker id is hard to test about react-archer HOT 5 CLOSED

Hmm @jrfferreira shouldn't you mock the react-archer dependency if you are unit testing another piece of code that implements this? If you are talking about testing react-archer itself then it can probably use a fixed value for the random generated id, e.g. by mocking Math.random() itself...

from react-archer.

Ah, indeed. Sorry, I did not think about this issue!

I should find another solution to get unique ids for each arrow.

Any suggestion welcome 😊

from react-archer.

Hi @robinvenneman, just for clarification, I'm using snapshots (with enzyme) to guarantee that the result of the implementation (SVG) will always be the same.

from react-archer.

Hi @jrfferreira!
I guess @robinvenneman's answer still makes sense. You can mock Math.random() in your snapshot tests so that it always returns the same value (or a value that is incremented at each function call so that arrow markers don't get a duplicate id).

Still, I'll try to come up with a better internal solution. Having random ids like that is not ideal.

from react-archer.

It feels like this is not really an issue, since solutions were provided. I said I'd improve the fact that there random IDs but actually I can't really find any downsides about this solution for now.

Closing, might reopen if needed!

from react-archer.