Git Product home page Git Product logo

Comments (10)

awdavis avatar awdavis commented on September 23, 2024 1

I walked around in the Nether and rerendered, and it doesn't seem to show any unfinished chunks in the area where I walked, so I'll consider that to be a good sign! (Unfinished chunk pins are off, but the corrupt chunk pins are on.)

before:
image

after:
image

from blockmap.

piegamesde avatar piegamesde commented on September 23, 2024

I am sorry, but the download link requires me to log in. I suspect that it is bound to your files from your account, so it wouldn't work either way. If you don't mind, please send me the failing file (r.-2.-3.mca in the End folder).

from blockmap.

awdavis avatar awdavis commented on September 23, 2024

from blockmap.

awdavis avatar awdavis commented on September 23, 2024

GitHub won't allow uploading .mca files, so here it is in zip format: r.-2.-3.zip

from blockmap.

piegamesde avatar piegamesde commented on September 23, 2024

I just pushed a potential fix to the develop branch, please check it out

from blockmap.

awdavis avatar awdavis commented on September 23, 2024

Thanks, I built the CLI jar from the develop branch and confirmed that my original CLI commands run to completion and no longer produce any errors, so this seems like an improvement.

However, by building manually, I was able to run the GUI for the first time ever (since I am on Windows), and based on the pins, it still seems to note a bunch of corrupt chunks in the End and in the Nether dimensions only. It seems potentially related to the original issue.

End example here:
image

java.lang.NullPointerException: Cannot read field "isTranslucent" because "colorData" is null
	at de.piegames.blockmap.renderer.ChunkRenderer_1_18.renderChunk(ChunkRenderer_1_18.java:274)
	at de.piegames.blockmap.renderer.RegionRenderer.renderRaw(RegionRenderer.java:149)
	at de.piegames.blockmap.renderer.RegionRenderer.render(RegionRenderer.java:61)
	at de.piegames.blockmap.world.RegionFolder$WorldRegionFolder.render(RegionFolder.java:179)
	at de.piegames.blockmap.gui.RenderedMap.run(RenderedMap.java:97)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

Nether example here:
image

java.lang.NullPointerException

This makes me think something still isn't quite right...

For comparison, here is a rendering of the Overworld:
image

from blockmap.

awdavis avatar awdavis commented on September 23, 2024

In the released GUI, there are lots of "Corrupt chunks" in the Nether dimension:
image

In the develop branch GUI, those are instead shown as "Unfinished chunks" in the Nether dimension:
image

In the released GUI, the End has many "Corrupt chunks" as well:
image

In the develop branch GUI, the End only has a few "Unfinished chunks" and doesn't show any "Corrupt chunks." It also only seems to display the "End city" pins that are near an unfinished chunk pin, and the rest do not appear for some reason.
image

from blockmap.

piegamesde avatar piegamesde commented on September 23, 2024

Thank you for the information. My fix does not appear to work as hoped. I have pushed a second attempt onto the developer branch, please try it out and see if it improves things.

from blockmap.

awdavis avatar awdavis commented on September 23, 2024

I downloaded the new version and ran gradle regenerate and gradle previewRelease, like I did last time. Here are the results from the GUI:
image

image

I am not sure what changes I am supposed to be looking for, but I don't see any obvious difference from since previous commit. I still see the same number of "Unfinished chunks" pins as before.

from blockmap.

piegamesde avatar piegamesde commented on September 23, 2024

Try walking to those "unfinished" chunks in Minecraft. If they render fine afterwards, nothing's wrong. Otherwise, please send me a region file with them so that I may take a look.

from blockmap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.