Comments (3)
@willclarktech, thanks.
What tool do you use to see some a11y complains?
I can't see any in Chrome or with Visual Studio linting tools.
I would not remove role="group"
now to avoid a breaking change.
But eventually we could change the documentation to use a div
instead of a fieldset
.
Not sure yet.
from pico.
Hm, I thought it was standard a11y linting, but it seems this is raised by Svelte for VSCode: https://svelte.dev/docs/accessibility-warnings#a11y-no-redundant-roles
To be clear, this isn't a blocker for me. I just thought default roles were worth considering.
from pico.
As role="group"
can be used with a div
, and we can't ship a breaking change, we should not change anything.
Perhaps the documentation could be improved.
from pico.
Related Issues (20)
- aria-busy with tooltip unexpected rendering HOT 2
- Form group with hidden input (Pico v2) HOT 2
- Details has a temporary visual gap after opening
- Forced dark theme doesn't work on HTML elements. HOT 4
- React Toastify Not Working properly
- v2: the selected options of an unfocussed select multiple element are not readable in dark mode HOT 5
- Missing Theme Builder HOT 2
- Remove "cursor: default" HOT 2
- v2: Card footers are not aligned in grid HOT 1
- Vertical distance between sections is too small compared to spacing between h3 h4, etc. HOT 3
- Use `button` instead of `a` for closing modals HOT 8
- Cards (`<article>` tags) have poor contrast with background in light mode HOT 2
- Grid with inputs has incorrect gap on mobile devices HOT 3
- Modal component is relying too much on Javascript HOT 9
- Input shadows are offset incorrectly in Firefox HOT 2
- Unable to use on Hugo v0.122.0 via Dart Sass HOT 6
- SassError: "This variable was not declared with !default in the @used module" HOT 3
- v2: inconsistent switch states HOT 5
- Spinner not fully visible in the `<code>` element HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pico.