Git Product home page Git Product logo

Comments (3)

lucaslarroche avatar lucaslarroche commented on June 13, 2024

@willclarktech, thanks.
What tool do you use to see some a11y complains?
I can't see any in Chrome or with Visual Studio linting tools.

I would not remove role="group" now to avoid a breaking change.
But eventually we could change the documentation to use a div instead of a fieldset.
Not sure yet.

from pico.

willclarktech avatar willclarktech commented on June 13, 2024

Hm, I thought it was standard a11y linting, but it seems this is raised by Svelte for VSCode: https://svelte.dev/docs/accessibility-warnings#a11y-no-redundant-roles

To be clear, this isn't a blocker for me. I just thought default roles were worth considering.

from pico.

lucaslarroche avatar lucaslarroche commented on June 13, 2024

As role="group" can be used with a div, and we can't ship a breaking change, we should not change anything.
Perhaps the documentation could be improved.

from pico.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.