Comments (5)
Thanks for your report, indeed, handling the legacy CNAME records file was missing in the v5 Teleporter import routines. Unfortunately, I don't have a full archive myself which I could use for testing. But I guess you could give me a hand on this one?
Please run
pihole checkout ftl fix/teleporter_v5_cnames
and test importing your archive again. The CNAME records should now be imported. If not, then something more fundamental is missing and I will need a demo archive to find this out myself.
edit Please note that the binary will only be available in about 20-30 minutes after I post this message. So long, harmless errors are expected when you run the checkout
command.
from adminlte.
It looks like that's not possible since I'm using a Docker image.
dns3:/# pihole checkout ftl fix/teleporter_v5_cnames
Function not supported in Docker images
from adminlte.
V6 containers have the checkout command disabled, but if I'm reading the issue correctly you need to run this in a v5 container (in which checkout is enabled) and then export as it is the v5 code that needs fixing to include the records that are missing from your export.
Then you should be able to import that file into the V6 container
Disregard, Speaking to @DL6ER he points out it is meant for a v6 container.
In order to use custom branches in a v6 container, you need to rebuild locally. See this section of the v6 readme:
But in short, clone the repo locally, then issue the following command:
docker buildx build src/. --tag pihole_custom --build-arg FTL_BRANCH=fix/teleporter_v5_cnames --no-cache
then drop pihole_custom
into your compose file in place of pihole/pihole:development-v6
from adminlte.
docker buildx build src/. --tag pihole_custom --build-arg FTL_BRANCH=fix/teleporter_v5_cnames --no-cache
I don't understand why, but this command will not work. Docker is claiming that the --tag
(or -t
) is invalid. I've run docker build
hundreds of times with the --tag
flag without issue, and just ran it again for another build.
I cloned the repo using gh repo clone pi-hole/docker-pi-hole
into the directory repo. Then ran docker buildx build repo/src/. --tag custom-pihole-v6 --build-arg FTL_BRANCH=fix/teleporter_v5_cnames --no-cache
.
Result:
unknown flag: --tag
See 'docker --help'.
from adminlte.
Sorry for the VERY delayed response here... life has been quite hectic.
I have since added a simplified build command to the docker repo (documentation here) which should simplify the command to:
./build.sh -t custom-pihole-v6 -f fix/teleporter_v5_cnames
from adminlte.
Related Issues (20)
- Group assignment dropdown not always populated HOT 4
- Local DNS records and CNAME don't show pagination buttons HOT 11
- After clicking on the +/- icon they keep the "active" state making them nearly invisible with dark theme HOT 1
- After datatables update, tables are no longer striped HOT 1
- Save button on boxed layout outside of content area HOT 1
- SQL-Error on fresh installation on Raspberry HOT 3
- Web GUI add domain to whitelist / blacklist is added only in default group HOT 1
- No log in for a week HOT 7
- admin/scripts/pi-hole/php/customdns.php and admin/dns_records.php: CORS is something the browser handles, not the server HOT 3
- /admin/scripts/pi-hole/php/customdns.php persistently fails even with password disabled HOT 2
- Update Gravity page is redirect depending on the settings level HOT 1
- An entry in the blacklist is not being blocked HOT 10
- Mapping 2 MAC addresses to the same IP address not displayed correctly on web HOT 2
- "Total queries over last 24 hours" empty HOT 4
- NAN on Admin Stats with Multiple Containerized Pihole Admin Consoles HOT 15
- Glow effect in "Total Queries" box result in blurry text. HOT 5
- Universal Time Displayed in Firefox Instead of Local Time HOT 3
- Teleporter import adds "default" to all domainlist_by_group.json entries. HOT 1
- Disabled Blocking doesn't get resumed after timer expiry. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adminlte.