Git Product home page Git Product logo

Comments (4)

rudiedirkx avatar rudiedirkx commented on June 16, 2024

The playground doesn't show files, or "in context of class ClassName", which is very confusing in this case. This is what local phpstan shows:

 ------ ---------------------------------------------------------------------------------------------------
  Line   HasCategories.php (in context of class App\Service\Categories\BaseTest)
 ------ ---------------------------------------------------------------------------------------------------
  10     Access to an undefined static property static(App\Service\Categories\BaseTest)::$category_prefix.
 ------ ---------------------------------------------------------------------------------------------------

with slighty different names.

from phpstan.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

In this second case, the concrete class TestTwo really doesn't have the required static property, which would be a real PHP error: https://phpstan.org/r/5567595d-5e09-4111-ad9a-6fd71e162e99 But PHPStan doesn't detect it, because it's not "in context of BaseClass".

from phpstan.

ondrejmirtes avatar ondrejmirtes commented on June 16, 2024

Traits are analysed in context of each class that uses them. And it doesn't matter whether the class is abstract or not. Your code is dangerous. It's not obvious at all that class extending BaseTest should have this property.

You can switch to an abstract method. That's enforceable by the language and by static analysis.

from phpstan.

rudiedirkx avatar rudiedirkx commented on June 16, 2024

Why does dangerous matter? That's what stan is supposed to detect, right? But it doesn't detect the actual bug (TestTwo doesn't have the static property), and it does detect the non-bug. Seems like a bug, but okay, maybe it's an edge case of bad programming.

from phpstan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.