Feature request: Disallow uninitialized properties about phpstan-strict-rules HOT 7 CLOSED

It looks like that the default value of a ?type property is not null, it is still uninitialized.

https://3v4l.org/oanOO

Setting null directly works.

public ?Bar $bar = null;

https://3v4l.org/KqLoA

from phpstan-strict-rules.

See this article: https://phpstan.org/blog/detecting-unused-private-properties-methods-constants

from phpstan-strict-rules.

Clarification: when typed as ?type the property is defaulted to null, which is not the same as uninitialized, and which should not trigger the error.

from phpstan-strict-rules.

Hi, this is difficult to get right, because PHP specifically allows the property to be uninitialized until used for the first time. So the property doesn't have to be initialized in the constructor... Any opinion how to tackle this?

from phpstan-strict-rules.

Is the following possible:

1. When loading a class, collect all typed properties which are not nullable or do not contain a default value.
2. When analysing the __construct() method, see which of those variables are receiving a value.

Or would this require extensive juggling inside the analyzer code? Of course this could end up deep when we start to factor in calling other class methods that do the property setting, or if some external entity is used to set the value.

from phpstan-strict-rules.

PHP specifically allows the property to be uninitialized until used for the first time.

That's right, and for some users that might be a fine way to program.

So the property doesn't have to be initialized in the constructor.

That's the point where strict rules could apply and require initialization is completed during construction. Properties that are not lazily initialized might still be allowed, but have to be checked before access through isset().

from phpstan-strict-rules.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpstan-strict-rules.