Feature request: forced strict_types=1 declaration about phpstan-strict-rules HOT 7 CLOSED

I've made it really easy to implement such rule: phpstan/phpstan@ed81c3a

from phpstan-strict-rules.

Yeah, since @localheinz has DeclareStrictTypesRule in https://github.com/ergebnis/phpstan-rules, we can close this :) Enable it along with the baseline is the recommended approach :)

from phpstan-strict-rules.

from phpstan-strict-rules.

@ondrejmirtes well done, thanks! At least makes a custom extension for it simpler to implement I think, in case no "official" extension provides this later on.

from phpstan-strict-rules.

@rask

You might like ergebnis/phpstan-rules#79!

from phpstan-strict-rules.

Check out slevomat/coding-standard, there’s a sniff for that.

As far as I can tell it (and similar) solutions will only be useful only when you're in a position to apply them to the whole codebase. While they provide a way to disable the sniff on a case-by-case basis, that is not a viable solution for when you're inheriting a legacy codebase without existing tests and want to enforce better conventions for any new code. The old code can then gradually transformed to be more in-line with the new standards.

Having this feature as part of phpstan combined with the baseline functionality seems like a better approach.

from phpstan-strict-rules.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpstan-strict-rules.