Comments (6)
mhujer
commented on May 25, 2024
1
See Static vs. Non-Static Usage of Assertion Methods (PHPUnit docs).
Maybe the rule should be somehow configurable to allow this special case?
from phpstan-strict-rules.
ondrejmirtes
commented on May 25, 2024
Hi, yes, that rule would be awesome :)
On Wed, 27 Dec 2017 at 21:30, Lukáš Unger ***@***.***> wrote:
Hi. Would there be interest in a new rule that checks that static methods
are called with :: and not with ->? I see that fairly regulary in the
wild (mainly with PHPUnit's asserts) and it's driving me crazy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAGZuA9HPSJymYt7SrrMHFrRoUGBNBrwks5tEqjrgaJpZM4RNyio>
.
--
Ondřej Mirtes
from phpstan-strict-rules.
lookyman
commented on May 25, 2024
@mhujer I have read that and I agree with the statement that there is no 'right' way. But since this package contains opinionated rules, I am trying to choose the right way. If the method is declared static, it should be called statically..
As for the configurable part, I could hardcode in some check for PHPUnit and allow a parameter to control it's behavior, but it seems to defeat the purpose..
from phpstan-strict-rules.
ondrejmirtes
commented on May 25, 2024
@mhujer I think that you can simply ignore the errors using ignoreErrors for PHPUnit asserts :)
from phpstan-strict-rules.
ondrejmirtes
commented on May 25, 2024
PR merged :)
from phpstan-strict-rules.
github-actions
commented on May 25, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-strict-rules.
Related Issues (20)
- allRules parameters set to false do not turn off rules HOT 2
- Disable all rules does not work HOT 3
- Force `@return` to match return type HOT 2
- [1.5.0] Error after added `$bleedingEdge` constructor parameter HOT 5
- display the name of the rule in the log HOT 2
- Disallow offset access on string
- Missing `#[Override]` HOT 2
- Add `uselessTrim` rule for useless `trim()`
- Relaxed booleansInConditions to allow 0, 1? HOT 5
- Add support to requireParentConstructorCall for indirect calls
- `class-string` should not be settable using string literal HOT 2
- Disallow casting potential nulls to int/string/array HOT 1
- Disallow foreach by-reference
- checkDynamicProperties, setting variable in while loop condition gets reported as might not be defined HOT 2
- Using named arguments with in_array causes a function.strict error HOT 2
- disallowedLooseComparison - allow only DateTime/DateTimeImmutable HOT 4
- Check if override method does not rename parameters
- Overriding a vendor class member with imperfect type declaration: No way to not get errors HOT 3
- Upgrade to PHP-Parser 5 HOT 5
- False positive "Variable might not be defined" after `for` loop HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-strict-rules.