When using PHPUnit, assertions and some other methods are normally called dynamically

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Exclude PHPUnit asserts etc. from DynamicCallOnStaticMethodsRule? about phpstan-strict-rules HOT 7 CLOSED

phpstan commented on May 25, 2024

Exclude PHPUnit asserts etc. from DynamicCallOnStaticMethodsRule?

from phpstan-strict-rules.

Comments (7)

BluePsyduck commented on May 25, 2024 2

@eugcar In your phpstan.neon configuration file, add the following:

parameters:
  ignoreErrors:
    - '#Dynamic call to static method PHPUnit\\Framework\\.*#'

This will ignore the error for all relevant PHPUnit classes.

from phpstan-strict-rules.

mhujer commented on May 25, 2024

From https://phpunit.readthedocs.io/en/7.3/assertions.html#static-vs-non-static-usage-of-assertion-methods

A common question, especially from developers new to PHPUnit, is whether using $this->assertTrue() or self::assertTrue(), for instance, is “the right way” to invoke an assertion. The short answer is: there is no right way. And there is no wrong way, either. It is a matter of personal preference.

from phpstan-strict-rules.

ondrejmirtes commented on May 25, 2024

If you don’t agree with this rule and want to call PHPUnit methods as instance methods, simply put a regexp to ignoreErrors config key.

On Fri, 7 Sep 2018 at 18:18, Martin Hujer ***@***.***> wrote: From https://phpunit.readthedocs.io/en/7.3/assertions.html#static-vs-non-static-usage-of-assertion-methods A common question, especially from developers new to PHPUnit, is whether using $this->assertTrue() or self::assertTrue(), for instance, is “the right way” to invoke an assertion. The short answer is: there is no right way. And there is no wrong way, either. It is a matter of personal preference. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuHd9t-7obaqRe4rHVxxuZMv-y0W8ks5uYpxQgaJpZM4WfGvE> .

-- Ondřej Mirtes

from phpstan-strict-rules.