Git Product home page Git Product logo

Comments (6)

ondrejmirtes avatar ondrejmirtes commented on May 25, 2024

This is a really weird request 😊 My opinion is that phpstan/phpstan is a dev dependency and users of a package should not care about its dev dependencies. I don't really see a point in this.

When you're using a package, you should only care about its public interface and not about the internal implementation, let alone how it's developed.

Can you elaborate on why you want this?

from phpstan-strict-rules.

SignpostMarv avatar SignpostMarv commented on May 25, 2024

for making sure I don't forget to run phpstan/phpstan-strict-rules on all of the things :P

from phpstan-strict-rules.

SignpostMarv avatar SignpostMarv commented on May 25, 2024

or to phrase it another way; I might remember to composer require --dev phpstan/phpstan on my packages, but if I then go and composer require said package on another package, it'd be nice to have a little reminder to say "hey, you're using phpstan/phpstan-strict-rules on the current pacakage, but one of the dependencies that uses phpstan/phpstan doesn't use phpstan/phpstan-strict-rules, maybe you want to go patch it in ?"

from phpstan-strict-rules.

ondrejmirtes avatar ondrejmirtes commented on May 25, 2024

That's a really weird solution to a problem 😊 What about having some composer.json template for all new projects or something like that? How do you make sure that you don't forget to add something else?

You might want to write your own Composer plugin for that, similar to https://github.com/Ocramius/PackageVersions.

from phpstan-strict-rules.

SignpostMarv avatar SignpostMarv commented on May 25, 2024

this is more for older packages that're still in use (i.e. really->far->down->the->dependency->chain) - I was doing a static analysis sprint at work today in between other tasks, stumbled across packages that were using a php-cs-fixer 1.x config class & possibly pre-0.8 phpstan:dev-master in require-dev.

from phpstan-strict-rules.

github-actions avatar github-actions commented on May 25, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpstan-strict-rules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.