Comments (4)
kubawerlos
commented on May 25, 2024
1
This repository contains additional rules that revolve around strictly and strongly typed code with no loose casting
So no, using in_array in non-strict mode should not be allowed.
from phpstan-strict-rules.
ondrejmirtes
commented on May 25, 2024
You both have a point.
I think that a setting should be in place. By default, false is reported as an error, but one can turn off this behaviour.
from phpstan-strict-rules.
kubawerlos
commented on May 25, 2024
Setting is fine, as long as I don't have to use it. I expect to have an error when I miss the non-strict mode in in_array (both explicit and implicit) during code review.
I still stand with my opinion that in_array in non-strict mode implies there is something wrong with the code design.
from phpstan-strict-rules.
github-actions
commented on May 25, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-strict-rules.
Related Issues (20)
- Foreach overwrites $variable with its value variable. - false positive? HOT 2
- False positive about possibly undefined variable after for loop HOT 3
- allRules parameters set to false do not turn off rules HOT 2
- Disable all rules does not work HOT 3
- Force `@return` to match return type HOT 2
- [1.5.0] Error after added `$bleedingEdge` constructor parameter HOT 5
- display the name of the rule in the log HOT 2
- Disallow offset access on string
- Missing `#[Override]` HOT 2
- Add `uselessTrim` rule for useless `trim()`
- Relaxed booleansInConditions to allow 0, 1? HOT 5
- Add support to requireParentConstructorCall for indirect calls
- `class-string` should not be settable using string literal HOT 2
- Disallow casting potential nulls to int/string/array HOT 1
- Disallow foreach by-reference
- checkDynamicProperties, setting variable in while loop condition gets reported as might not be defined HOT 2
- Using named arguments with in_array causes a function.strict error HOT 2
- disallowedLooseComparison - allow only DateTime/DateTimeImmutable HOT 4
- Check if override method does not rename parameters
- Overriding a vendor class member with imperfect type declaration: No way to not get errors HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-strict-rules.