Comments (3)
For improving this enhancement, you could do that :
public function save($strFilename = '') {
}
No ?
from phpword.
Yep, sure, this is good solution. This approach is backward compatible and takes minimum lines of new code. In the same time it has some disadvantages.
a) Not clear enough. An empty string doesn't seem to be a valid filename.
b) Logical issues. For example, I can't understand why API should "eat" an empty string on input just to save file in its current place. There is no logic.
c) Usage problems. Input string may be empty by a mistake. In your case API just saves the file instead of alerting somehow about the problem. My approach gives a chance to handle this situation (I didn't do that yet).
From the other hand, my approach makes the implementation more clear, logically correct and easy to use. In the same time it's not backword compatible and requires more lines of code than yours.
I thought that we are not competing here for some The Most Short Code award, so I gave preference to more clear and understandable code.
Does it makes sense?
from phpword.
Yes, now... I understand your approach and I agree with it. Thanks. I close your ticket.
from phpword.
Related Issues (20)
- RTF increases support for Chinese reading
- Corrupted file after SaveAs from templateProcessor
- When I've tried to use it i'd get the error: "Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 262144 bytes) ". I've modified the amount of memory via ini_set but the error continues
- Error: Class "ZipArchive" not found (0) En el archivo I:\MisWebs\test\vendor\phpoffice\phpword\src\PhpWord\Shared\ZipArchive.php en la línea: 138 HOT 1
- not adding header and footer on pdf:(dompdf and mpdf) HOT 3
- setImageValue added image doesn't have common image properties
- Uncaught ValueError: Invalid or uninitialized Zip object
- Avoid page break inside table
- Why not use a better HTML parser?
- Cant find how change list numbering font-size and font-family?
- ZipArchive::close(): Renaming temporary file failed: Permission denied{ "message": "Invalid or uninitialized Zip object" HOT 3
- IOFactory::load failed and the funtion setCommentReference not working HOT 1
- Special char (&) is breaking word document HOT 1
- IOFactory::Load fails with "Cannot add Title in Header."
- Not able to add styles to some tags and listitems in addhtml
- empty li on odf (docx ok)
- dompdf version bump to include 3.0 when?
- Trouble Interacting with Dropdown FormField
- Error reporting of cloneRow
- Multicolumn layout is not working. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpword.