Postprocessing of documents returned by Template class before moving to final destination about phpword HOT 3 CLOSED

For improving this enhancement, you could do that :

public function save($strFilename = '') {
}

No ?

from phpword.

Yep, sure, this is good solution. This approach is backward compatible and takes minimum lines of new code. In the same time it has some disadvantages.
a) Not clear enough. An empty string doesn't seem to be a valid filename.
b) Logical issues. For example, I can't understand why API should "eat" an empty string on input just to save file in its current place. There is no logic.
c) Usage problems. Input string may be empty by a mistake. In your case API just saves the file instead of alerting somehow about the problem. My approach gives a chance to handle this situation (I didn't do that yet).

From the other hand, my approach makes the implementation more clear, logically correct and easy to use. In the same time it's not backword compatible and requires more lines of code than yours.

I thought that we are not competing here for some The Most Short Code award, so I gave preference to more clear and understandable code.

Does it makes sense?

from phpword.

Yes, now... I understand your approach and I agree with it. Thanks. I close your ticket.

from phpword.