Comments (6)
htmlspecialchars
change (&, ', ", <, >) by theirs HTML equivalents.
After having inserted some texts in a DOCX file, i confirm the need of use of htmlspecialchars
:
<w:p>
<w:pPr>
<w:pStyle w:val="style0"/>
<w:rPr><w:rFonts w:cs="Mangal" w:eastAsia="SimSun"/></w:rPr>
</w:pPr>
<w:r>
<w:rPr></w:rPr>
<w:t>Texte&Texte</w:t>
</w:r>
<w:r>
<w:rPr></w:rPr>
<w:t>'Texte</w:t>
</w:r>
<w:r>
<w:rPr></w:rPr>
<w:t>"</w:t>
</w:r>
<w:r>
<w:rPr></w:rPr>
<w:t>Texte<Texte>Texte</w:t>
</w:r>
</w:p>
from phpword.
Fixed in develop branch
from phpword.
I've tested this with last dev-master (38d3d7b), it works like a charm
Thanks!
from phpword.
Guys, I wouldn't agree with you.
First, as for me, I escape data before exporting it in any format (HTML, OOXML, no matter). Second time escaping brokes my data.
Second, there are already tons of libraries which offer escaping functionality (e.g. Zend/Escaper). And they are pretty good. Data escaping is much more than single htmlspecialchars
call which we have here.
As regards escaping strategy. Output should be escaped and everybody knows this. Escaping should be performed after all data transformations. It's a well-known rule too. PhpWord is a library which helps to build OOXML (and other) documents, based on the provided data. It doesn't change the data, it just packs the data into another format. There are also libraries which help to build HTML pages. So, if we escape data before submitting to HTML builders, why not to escape data before submitting to PhpWord? I don't see any difference here. And my applications goes this way. I can support tons of different formats and escape only once and in one place. Morever, there is no need to implement the same escaping functionality in all libraries for all formats of documents. Just escape data out of the library. Remember: escape once, use multiple times. :)
So, I'm gonna to remove the htmlentities
call. Any objections?
from phpword.
New escaping functionality will be considered in scope of #483.
from phpword.
thanks, i was strangled with < as well, thanks
from phpword.
Related Issues (20)
- Images produced by templateProcessor->setImageValue look different in Windows versus Mac HOT 1
- Reader ERROR -> libxml_disable_entity_loader() is deprecated in PHP8
- TemplateProcessor deleteBlock is not working HOT 2
- Extension for PHPWord/src/PhpWord/IOFactory.php::extractVariables
- Contents of the cells are not vertically centered
- cloneBlock property does not function properly with files exceeding 145KB in the template.
- Invalid image: zip:///tmp/......../iamge4.png
- Incorrect variable naming conventions
- Replace all image by their alttext attribute
- Race condition in ZipArchive::$tempDir
- When using addHtml function, the width of the image is not measured in pt
- RTF increases support for Chinese reading
- Corrupted file after SaveAs from templateProcessor
- When I've tried to use it i'd get the error: "Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 262144 bytes) ". I've modified the amount of memory via ini_set but the error continues
- Error: Class "ZipArchive" not found (0) En el archivo I:\MisWebs\test\vendor\phpoffice\phpword\src\PhpWord\Shared\ZipArchive.php en la línea: 138 HOT 1
- not adding header and footer on pdf:(dompdf and mpdf) HOT 3
- setImageValue added image doesn't have common image properties
- Uncaught ValueError: Invalid or uninitialized Zip object
- Avoid page break inside table
- Why not use a better HTML parser?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpword.