Missing commit for release 3.3 about phplist3 HOT 6 CLOSED

Do we need a PR for this? Or is it just missing from the release notes?

from phplist3.

Duncan, I must have missed your commit. The branch is gone. Can you re-push it?

from phplist3.

@michield Can you just copy those lines (or amend the existing code to do something equivalent)? This is the existing code that replaces one character by two (bin2hex generates two characters from one random byte). The following hex2bin fails due to an odd length input.

                    $masked = substr($linkUUID,0,14).bin2hex(random_bytes(1)).substr($linkUUID,15).
                        substr($cached[$messageid]['uuid'],0,14).bin2hex(random_bytes(1)).substr($cached[$messageid]['uuid'],15).
                        substr($userdata['uuid'],0,14).bin2hex(random_bytes(1)).substr($userdata['uuid'],15);

from phplist3.

OK, I committed a139f35

but it works for me either way. I'm not sure why. I think your version is safer though, as it forces the bin2hex into one character. Maybe it's not always the same on all systems.

from phplist3.

With the original code, when sending a test message there was this error reported for each url

and the tid parameter in links in the text format email was empty
Here is a link
http://strontian/lists/lt.php?tid=&hm=5af08ebfceb4eb0da430799e349afe38482f5c727cc547dd21a3c146d5e32f5f

from phplist3.

strange. That didn't happen for me. I guess some system differences,,,,

from phplist3.