Git Product home page Git Product logo

Comments (4)

oliverklee avatar oliverklee commented on July 20, 2024

Hi @kilip, thanks for the discussion points.

I'm fine with changing to namespace PHPList\Core; (or namespace PhpList\Core;, which I prefer so we have real CamelCase). We should also change the package name to just phplist/core and also rename the GitHub repository to core.

As for the PHPUnit configuration: In the long term, we might need multiple configuration files anyway. So I'd prefer to keep them in a directory. We'll shorten the call by adding a composer script.

Concerning the directory naming conventions: We're already working on this. Within tests/ and src/, the directories cannot be all-lowercase due to the PSR-4 autoloading.

@samtuke, @michield What do you think?

from core.

michield avatar michield commented on July 20, 2024

Yes, fine by me. phplist/core is more obvious. Eventually the version is irrelevant. We called it phpList4 to distinguish it. I like that better than things like "-new" as after some time it won't be new any longer.

There will however, for the time being, be some old and new aspect of the two phpLists, with eg the sending engine being in pl3. But eventually, the plan is to move away from that.

Camelcase wise, I really like "phpList" more than any other version. It's quite distinct.

from core.

samtuke avatar samtuke commented on July 20, 2024

I have changed the repository and Packagist name to 'core' following agreement above and am working on the composer.json changes in #275

from core.

samtuke avatar samtuke commented on July 20, 2024

Regarding directory naming conventions: all good that this is already agreed and in progress

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.