Optional trailing slash support about django-macros-url HOT 10 CLOSED

@dalberto I wait when it will be native in Django (or any alternative) because it is simple and covers 90% of user cases, but anyway, it is small, clear and integrated very well into Django, so I start all my projects from installing macros library :)

from django-macros-url.

Hi Darlin,

I think it is not good idea because for search engines "/page/" and "/page" are different (and for example better is to have 301 redirect from "/page" to "/page/"). This can be added only as option, better is to use append slash django feature (https://docs.djangoproject.com/en/1.9/ref/settings/#append-slash).

But anyway it is good idea, I will think (and will read django source code) about it.

Thanks!

from django-macros-url.

Thanks for the speedy reply.
On second thought, I suppose this is unnecessary because a macro can be written for the optional trailing slash. I'm not sure if this will have unknown side-effects.

from django-macros-url.

@dalberto yes it can of course. But I am not sure it is good way, please check APPEND_SLASH django feature.

from django-macros-url.

https://github.com/django/django/blob/master/django/middleware/common.py#L69

from django-macros-url.

Django handles this best way I think ;)

https://github.com/django/django/blob/master/django/middleware/common.py#L39

from django-macros-url.

Oh, thanks! Sorry for the extraneous request, feel free to close this issue.

from django-macros-url.

Only one stuff can be done - auto trailing slash (strict, all urls ends with "/") to make all urls more elegant and allow developer forget about trailing slashes at all. I mean force "/" without "?".

from django-macros-url.

I double checked source code, looks like force add slash to end of rule is bad idea because user will not have any chance to remove it, only hacks like str(url(..)) but it is ugly for me and I don't want to do it. So I close the issue.

Anyway thanks for your ideas.

from django-macros-url.

Thanks for your help nevertheless. This library has proven very useful!

from django-macros-url.