Git Product home page Git Product logo

Comments (2)

noplanman avatar noplanman commented on June 2, 2024

I've not looked deeply into this yet, but since that data gets passed via a message, you should be able to get it inside your GenericmessageCommand class. Have you tried this?

class GenericmessageCommand extends SystemCommand
{
    public function execute(): ServerResponse
    {
        $data = $this->getMessage()?->getWebAppData()?->getData();

        // check if $data isn't null and do something with it.
    }
}

from core.

mlocati avatar mlocati commented on June 2, 2024

That's what I'm doing right now.

But I think the code has an issue (not only for Web Apps.

If $type is not 'command', this line makes it so $command_tmp always contains a string with the first character in upper case, and all the other characters in lowercase (for example: 'web_app_data''Webappdata').

But this line makes it so all the command handlers have a snake_case syntax (for example: 'WebAppDataCommand''web_app_data').

That way, when $type !== 'command', we'll NEVER have a match between command names derived from messages and command classes here.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.