Git Product home page Git Product logo

Comments (6)

LeSuisse avatar LeSuisse commented on June 13, 2024 3

Maybe we should move to another method like convert_uuencode.

I'm not sure this is needed, since $charset will never be base64, uuencode, html-entities or quoted-printable.

Something like does not seem to trigger any regressions:

--- a/src/Charset.php
+++ b/src/Charset.php
@@ -355,7 +355,7 @@ class Charset implements CharsetManager
             'strtolower',
             array_unique(
                 array_merge(
-                    $enc = mb_list_encodings(),
+                    $enc = array_diff(mb_list_encodings(), ['BASE64', 'UUENCODE', 'HTML-ENTITIES', 'Quoted-Printable']),
                     call_user_func_array(
                         'array_merge',
                         array_map(

Do you know why I don't see any deprecation notices on the last test run on PHP 8.2:
https://github.com/php-mime-mail-parser/php-mime-mail-parser/actions/runs/4324420290/jobs/7549225816

Yes, it depends on the value you have set for error_reporting, see #415

from php-mime-mail-parser.

iquito avatar iquito commented on June 13, 2024

This is also the main deprecation message in one of my applications since switching to PHP 8.2, would be great to adjust it!

from php-mime-mail-parser.

eXorus avatar eXorus commented on June 13, 2024

Thanks for the report, not sure to understand the issue yet.

Maybe we should move to another method like convert_uuencode.

Do you know why I don't see any deprecation notices on the last test run on PHP 8.2:
https://github.com/php-mime-mail-parser/php-mime-mail-parser/actions/runs/4324420290/jobs/7549225816

from php-mime-mail-parser.

daniesy avatar daniesy commented on June 13, 2024

This issue throws a 502 error in Laravel Valet configuration: upstream prematurely closed connection while reading response header from upstream, client...

@LeSuisse suggestion seems to fix it.

from php-mime-mail-parser.

eXorus avatar eXorus commented on June 13, 2024

Sorry, I don't have much time at the moment to dedicate to php-mime-mail-parser (a new baby for those who know). If someone would like to make a clean PR with tests, I would be very happy to review and merge it. Thank you in advance.

from php-mime-mail-parser.

eXorus avatar eXorus commented on June 13, 2024

I wanted to express my gratitude for your assistance in addressing the bug, and I apologize for the delay in getting back to you on the PR. Your input was truly valuable. I'd like to inform you that the release is now available.
https://github.com/php-mime-mail-parser/php-mime-mail-parser/releases/tag/8.0.2

from php-mime-mail-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.