Interesting bug about polyfill HOT 7 OPEN

I know it's been quite a while, sorry I didn't get to this earlier.

I've just done an overhaul of our tests:

• Run on a system using the polyfill: Everything is ok.
• Run on a system using the extension: Same result as above.

To save on work, I've changed the code to not use references as described above. I thought you would want to know that there is still a references issue lurking in there somewhere.

from polyfill.

So strange. 🤔

I'll take a look asap. Thanks for the report. :)

from polyfill.

I have a feeling it's because we're not dereferencing consistently. I don't think it's add vs constructor, but the fact that you're using references in the first case.

What's your code for hash and equals?

from polyfill.

It will definitely be because of the references.

    public function equals($obj): bool
    {
        return get_class($this) === get_class($obj)
            && $this->hash() === $obj->hash();
    }

    public function hash()
    {
        return (string) $this;
    }

    public function __toString(): string
    {
        return (string) $this->identity;
    }

Just a simple set of functions as it's a uuid.

from polyfill.

I think this has now been fixed in the extension?

from polyfill.

Great if it has! I will try to reproduce this (the code has moved on since I logged it).

from polyfill.

Thanks @designermonkey, I'll try to add a failing test for this.

from polyfill.