Enhance InstallerScript for local files about scripts HOT 8 CLOSED

For me it should be a different quick script

from scripts.

Really? For me the definition of InstallerScript is to install a given executable. I would have done it like this:

if (this._url) {
  new Downloader()...
} else {
  setupWizard.browse();
}

from scripts.

Why using conditions when you can take advantage of inheritance and abstraction? :-)

from scripts.

I don't see how the go() method could be implemented with inheritance without duplicating most of the code in it.

from scripts.

Download is providing an absolute path to a file, same for browse()

This is the only one difference between the two quick scripts. I think we can create a protected method that process the installation from an absolute file

from scripts.

Ok. So we have LocalInstallerScript and RemoteInstallerScript inheriting from InstallerScript. InstallerScript gets a method installationFile(). But how to show the browse dialog in LocalInstallerScript if the go() shall be implemented in InstallerScript?

from scripts.

It should be a callback property

from scripts.

I see. Yes that should work. I will give it a try.

from scripts.