Git Product home page Git Product logo

Comments (9)

lingdoc avatar lingdoc commented on August 30, 2024

Another 2 questions:

  1. the paper also mentions using Gradient Clipping for language modeling, and I assume that this was done as part of the optimization of the Adam optimizer, but just to clarify, was this norm scaling?
  2. the paper mentions gating as well, but is this implemented in the current keras version?

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

@lingdoc this is in my TODO list. I'll dig into that when I have a bit of time. In ~1 week from now!

from keras-tcn.

lingdoc avatar lingdoc commented on August 30, 2024

btw, great implementation! I'm comparing it with a BiLSTM-CNN variant on a text classification problem and getting similar results with half the runtime.

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

That's great! Thank you :)

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

Just for info, I'm working on a PR to make the implementation identical to the paper: #42

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

Merged. Only weight norm is missing
141ef1c

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

@lukeb88 :

  1. In the paper, they don't talk about stacking various dilated convolutions (parameter nb_stacks):
    I think I understood what you discussed here, but how this changes instead of just increasing the number of dilations?

=> fixed I set the nb_stacks to 1 for all the examples. Results are the same.

how this changes instead of just increasing the number of dilations?

cf. https://arxiv.org/pdf/1609.03499.pdf

  1. In the single residual block (in residual_block()), why is there only one convolutional layer instead of 2 as in the paper?
    It's just a simplification?

=> Was a simplification. But I fixed it!

from keras-tcn.

lukeb88 avatar lukeb88 commented on August 30, 2024

@philipperemy I supposed that the idea of stacking dilated convolution was taken from the Wavenet paper!
Thanks for your clarification...

great work, btw!!!

from keras-tcn.

philipperemy avatar philipperemy commented on August 30, 2024

@lukeb88 yeah the idea was taken from wavenet!
Thanks I highly appreciate :)

from keras-tcn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.