Git Product home page Git Product logo

Comments (9)

cblavier avatar cblavier commented on May 9, 2024 1

can you try with a fully qualified name in your block?

%Story{
  id: :tabs,
  attributes: %{},
  block: """
  <BrmblWeb.UI.Navigation.Tabs.tab is_active to="/" label="Tab1" />
  <BrmblWeb.UI.Navigation.Tabs.tab to="/hi" label="Tab2" />
  """
}

from phoenix_storybook.

glennr avatar glennr commented on May 9, 2024 1

Thanks for that - this un-blocks me for now!

from phoenix_storybook.

cblavier avatar cblavier commented on May 9, 2024 1

from phoenix_storybook.

cblavier avatar cblavier commented on May 9, 2024 1

An entry example using new custom aliases / imports

defmodule NestedComponent do
  use PhxLiveStorybook.Entry, :component
  def function, do: &NestedComponent.nested_component/1

  def aliases, do: [MyStorybook.Helpers.JSHelpers]
  def imports, do: [{NestedComponent, nested: 1}]

  def stories do
    [
      %Story{
        id: :default,
        block: """
        <.nested phx-click={JSHelpers.toggle()}>hello</.nested>
        <.nested phx-click={JSHelpers.toggle()}>world</.nested>
        """
      }
    ]
  end
end

from phoenix_storybook.

glennr avatar glennr commented on May 9, 2024 1

@cblavier just spotted this. Awesome stuff mate.

You got a release candidate, or some other tag we can pull from?

from phoenix_storybook.

cblavier avatar cblavier commented on May 9, 2024 1

no release now, still a few tickets to ship.

In the meantime you can pull main branch. The issue is that, since it's not a proper hex release, you won't have the assets

in your mix.exs :

defp deps do 
  [{:phx_live_storybook, github: "phenixdigital/phx_live_storybook"}]
end

then from your shell

mix deps.get
cd deps/phx_live_storybook
mix deps.get
npm ci --prefix assets
mix assets.build

you should be ready to go, and take care of recent changes in router.ex (see CHANGELOG.md)

from phoenix_storybook.

glennr avatar glennr commented on May 9, 2024

That gets it to compile

The generated story remains verbose however:

<.tabs>
  <BrmblWeb.UI.Navigation.Tabs.tab is_active to="/" label="Tab1" />
<BrmblWeb.UI.Navigation.Tabs.tab to="/hi" label="Tab2" />
<./tabs>

(indentation appears broken, but Ive noticed that elsewhere)

from phoenix_storybook.

cblavier avatar cblavier commented on May 9, 2024

proper slots indentation 👌

CleanShot 2022-09-02 at 12 09 41

from phoenix_storybook.

glennr avatar glennr commented on May 9, 2024

yeah I spotted those changes in the Changelog. I gave it a stab yesterday, but the assets were tripping me up. Thanks a bunch for the workaround!

from phoenix_storybook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.