Git Product home page Git Product logo

Comments (8)

niden avatar niden commented on June 2, 2024

Moving to devtools

from phalcon-devtools.

Ultimater avatar Ultimater commented on June 2, 2024

Devtools relies on the Phalcon\Version class to check Phalcon's version.
This class had some of its methods deprecated and stated it was going to be removed in V5.
But the getVersion() method didn't. Thus the class shouldn't have disappeared in V5.
This would be a bug in cphalcon, not devtools.

from phalcon-devtools.

Ultimater avatar Ultimater commented on June 2, 2024

cc: @Jeckerson @niden

from phalcon-devtools.

niden avatar niden commented on June 2, 2024

The class is under the Support namespace in v5. We just have to change its instantiation and signature (no longer static methods).

from phalcon-devtools.

niden avatar niden commented on June 2, 2024

This needs to go back to devtools. Also, the question will be about versioning i.e. devtools for v5

from phalcon-devtools.

Ultimater avatar Ultimater commented on June 2, 2024

@niden Sorry for the confusion, I thought it was missing functionality being alarmed at seeing the class disappear without first deprecating the class with an alias class. But this would be a major version bump so can't be too picky as breaking changes are expected.

I'll work on implementing this in devtools.

from phalcon-devtools.

Ultimater avatar Ultimater commented on June 2, 2024

This has been fixed in 4.2.0

from phalcon-devtools.

MateusJ avatar MateusJ commented on June 2, 2024

i'm having this same issue.

from phalcon-devtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.