Comments (8)
arg
definitely should handle description. I've done quick investigation and found cause of this bug, it will be fixed soon.
Thank you very much for your feedback and kind words! I'm really happy that you have found this library useful.
from kgraphql.
After some more debugging I noticed that "deprecate" becomes the description.
.withArgs { arg<Int> { name = "page" defaultValue = 0 deprecate("becomes description") } }
from kgraphql.
That's true, I've messed up order of constructor arguments in DSL consumer, my bad, should have used explicit argument names.
from kgraphql.
@Paradoxia issue has been fixed and merged to master. It will come out with next release in coming days. Thank you for your report!
from kgraphql.
@pgutkowski Awesome thank you. I found a similar problem on property
type<Production> {
property<String?>("country") {
description = "Country description"
resolver { production -> production.country }
}
}
{
__type(name: "Production") {
name
description
fields {
name
description
type {
name
description
kind
ofType {
name
description
kind
}
}
}
}
}
---> Slice from result -->
{
"name": "country",
"description": null, <---- MISSING
"type": {
"name": "String",
"description": "The String scalar type represents textual data, represented as UTF‐8 character sequences",
"kind": "SCALAR",
"ofType": null
}
}
The query doesn't output the description i created for property "country".
from kgraphql.
It seems that you are doing the same thing as in #4, where property<>
invocation ads new property which duplicates existing kotlin property.
Please try to add description with
type<Production> {
property(Production::country) {
description = "Country description"
}
}
and see if description is missing.
In future there will be validation step added to ensure that extension properties do not shadow existing kotlin properties.
from kgraphql.
You are completely right. Code now works as expected. Handing out this
from kgraphql.
Thanks! Always happy to help
from kgraphql.
Related Issues (20)
- Extension property not working HOT 1
- Support for suspendable property resolvers HOT 2
- There is no instruction to help a new user to start the server and the client in this example. How can I run the server and start query? HOT 2
- LocalDate coercion issue HOT 2
- Support for suspendable schema execution HOT 1
- Property resolver with context HOT 8
- Scalar types within variables not working HOT 1
- How would I handle query/mutation authentication? HOT 4
- Print Schema? HOT 1
- Adding Context parameter to resolver causes errors in introspection HOT 3
- Fragments not resolving correctly on same data node
- Nested Fragments fail with property does not exist HOT 2
- LocalDate when passed as query variable HOT 1
- Leaking top level
- Is this the right way with using resolvers on a type? HOT 2
- Support for suspendable unionProperty resolvers
- Implement a DataLoaderDSL for batching
- Caused by: java.lang.NoClassDefFoundError: kotlinx/coroutines/experimental/CommonPool HOT 1
- When overwriting a property, the GraphQL repeats the original property unless ignored
- release 0.3.1 build? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kgraphql.