Git Product home page Git Product logo

Comments (2)

emcastillo avatar emcastillo commented on July 16, 2024 1

I will take care of this

from pytorch-pfn-extras.

kmaehashi avatar kmaehashi commented on July 16, 2024

Thank you for your contirbution!

It would be good to have LazyBatchNorm instead of having LazyBatchNorm*d-s since lazy ones know its desired shapes. Any thoughts?

I feel explicitness is one of the PyTorch's philosophy because they provide BatchNormXd (X=1,2,3) even though everything is implemented in hidden _BatchNorm class. https://pytorch.org/docs/master/_modules/torch/nn/modules/batchnorm.html
I think it's better to do as the Romans do.

Separate LazyBatchNormXd implementation will also make users easier to migrate from PPE's lazy implementation to PyTorch's upstream lazy implementation, which is under proposal in pytorch/pytorch#40493

from pytorch-pfn-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.