Git Product home page Git Product logo

Comments (3)

azambon avatar azambon commented on July 21, 2024

I had a chance to take a look at the code.
Here is a possible issue, in that the check volts[N_OUT] > volts[N_VIN]/2 does not seem to take into account that the ground pin may be connected to something other than ground. It should probably become something like volts[N_OUT] > (volts[N_VIN]+groundVolts)/2 after moving the definition of groundVolts to the top of the method.
Same here, where the volts[N_CTL]/2 expression does not yield the expected value in case of a non-ground negative supply. (volts[N_CTL]+groundVolts)/2 should fix it, I think.

I cannot find anything else in that file, so perhaps fixing those two items would be enough?

from circuitjs1.

pfalstad avatar pfalstad commented on July 21, 2024

yes, I think that is right.

from circuitjs1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.