Under certain circumstances, SpringPluginManager does not identify loaded plugins about pf4j-spring HOT 3 CLOSED

Sorry for late response. I understand what you say and I think that makes sense.
I am not sure if plugin.getPluginClassLoader().getParent() == classLoader is reliable.
The parent of PluginClassLoader is the application class loader.
I don't know how other people use PluginManager.whichPlugin but I pass as parameter only some classes that make sense (extensions, extension points, ...), classes that exist in the plugin jar/zip.

Can you give me a concrete example (from your application) of whichPlugin call when the actual implementation (without || plugin.getPluginClassLoader().getParent() == classLoader) failed?

from pf4j-spring.

@sfines
I don't know what to do with this issue.

Can you give me a concrete example (from your application) of whichPlugin call when the actual implementation (without || plugin.getPluginClassLoader().getParent() == classLoader) failed?

Do you have a response for above question?

the PluginClassloader should properly fill out the packages map and then use that or some other mechanism to determine ownership...

It's a solution. My idea is to keep PluginClassLoader as simple as possible, to be able to come with any ClassLoader implementation. We will see.

from pf4j-spring.

I will close this issue. I added a new section in documentation to explain in detail how classes are loaded in PF4J.

from pf4j-spring.