Comments (4)
Well that's why program.id is used. As program is cached by flags and those should contain all the required features. Do you have a test case?
from pex-renderer.
Test case:
- add log where pipeline creation happens in
getGeometryPipeline
:
pex-renderer/systems/renderer/standard.js
Lines 426 to 428 in 41759af
- go to gltf example
TextureSettingsTest
- see it failed doubleSided test because it doesn't go through pipeline creation and reuse another material (I assume)
- add id:
Material_${MaterialID++}
to material component returned value, see test passing
from pex-renderer.
I think that id was omitted on purpose to avoid material explosion. For now i would double check if we cache all the flags eg culling and long term find better approach than dirty flag.
from pex-renderer.
Should be fixed in v4 so closing.
from pex-renderer.
Related Issues (20)
- Layer system
- Reflection map prefiltering improvements HOT 5
- Provide default values when creating light components HOT 1
- Add support for attribute.dirty HOT 2
- Allow shadow map size customisation HOT 1
- Prevent camera helper rendering when rendering from the same entity camera component
- Renderer crashes on directional lights that don't cast shadows HOT 1
- Something is broken
- Directional light entity helper should not grow with light intensity HOT 9
- Maximum call stack size exceeded HOT 3
- Add basic render engine example
- Default skybox sunPosition HOT 1
- PostProcessing cleanup HOT 1
- Add custom attributeMap
- Camera clear color should be in linear space HOT 1
- [v4] material receiveShadows is not used
- PCSS shadows are camera dependent
- Bring light.radius range from 0...shadowMapSize to 0..1
- Line thickness is viewport aspect ratio dependent
- [glTF] xmag and ymag in glTF loaders shouldn't be halved
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pex-renderer.