Git Product home page Git Product logo

Comments (4)

vorg avatar vorg commented on September 25, 2024

Well that's why program.id is used. As program is cached by flags and those should contain all the required features. Do you have a test case?

from pex-renderer.

dmnsgn avatar dmnsgn commented on September 25, 2024

Test case:

  • add log where pipeline creation happens in getGeometryPipeline:
    if (!pipeline || material.needsPipelineUpdate) {
    material.needsPipelineUpdate = false;
    pipeline = ctx.pipeline({
  • go to gltf example TextureSettingsTest
  • see it failed doubleSided test because it doesn't go through pipeline creation and reuse another material (I assume)
  • add id: Material_${MaterialID++} to material component returned value, see test passing

from pex-renderer.

vorg avatar vorg commented on September 25, 2024

I think that id was omitted on purpose to avoid material explosion. For now i would double check if we cache all the flags eg culling and long term find better approach than dirty flag.

from pex-renderer.

vorg avatar vorg commented on September 25, 2024

Should be fixed in v4 so closing.

from pex-renderer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.