Disable the success notification about karma-osx-reporter HOT 8 CLOSED

Hi,

I'm not sure it should be implemented in the plug-in itself (after all it's a results reporter, not error notifier) but you might disable it in Notification Center preferences http://cl.ly/image/032e2y0T1E45

from karma-osx-reporter.

I agree. However, @petrbela I'm thinking you're misunderstanding @arosca. What I think we both experience is that's annoying with the "PASSED" notification whenever you save a file.

What would be nice is a configurable property, say "notificationMode" that could be

1. "failchange" - Remember the last result. Only show success results if last one was a fail
2. "change" - Remember the last result. Only show notifications is last one was different
3. "always" - Like today

from karma-osx-reporter.

@staeke Yeah that makes sense. Do you want to propose an implementation? I probably won't have time until Friday.

from karma-osx-reporter.

This week, me neither unfortunately.

from karma-osx-reporter.

I had a similar issue and patched in with inspiration from your discussion. See the fork commit at hmps@48f3a26

If you like the solution I can make a PR.

from karma-osx-reporter.

@hmps looks nice, can you PR? Thanks!

from karma-osx-reporter.

Have created a PR. Sorry for the very late response here...

from karma-osx-reporter.

Available in v0.2.0. Thanks @hmps!

from karma-osx-reporter.