Comments (7)
Thank you. The self._init bound variable is evidently cruft from an earlier iteration where the first received message would otherwise have been lost.
Deleting the variable and all references to it works, and should fix the problem.
from micropython-iot.
Think so too.
from micropython-iot.
I was wrong closing this so early. It does not fix the whole problem.
if not mid:
isnew(-1) # Clear down rx message record
# _init : client has restarted. mid == 0 server power up
if not mid or isnew(mid):
This means, that if the client receives a message with mid==0, the bytearray will get reset, so the duplicate message with mid==0 will reset it again and the library will never recognize a duplicate message with id==0.
So the fix could be to initialize isnew(-1) at the start of the _reader and make the server reset it too on reconnect.
from micropython-iot.
Also the line
if not mid or isnew(mid):
would need to be changed to
if isnew(mid):
so that the mid 0 will get added to the bytearray.
from micropython-iot.
I'm not sure that will fix it. The first message would have been sent before the outage. .reader() would then be canceled and restarted. It would fail to recognise the dupe.
I think after an outage we need to do the following, in ._run(). If the last received mid was zero we don't need to clear the generator as that must be its only contents. Otherwise we clear it down.
My brain hurts. I'll look at this in the morning :) What do you think?
from micropython-iot.
Mine hurts now too. Will think about it again tomorrow. Forgot that the first message after an outage is already a dupe and possibly more than one message after an outage so only storing the last mid wouldn't solve it.
from micropython-iot.
I think I've figured it out. Will post a fix for your review.
from micropython-iot.
Related Issues (13)
- Some thoughts to the general design HOT 10
- bad_wifi executed if wifi not connected at library start HOT 2
- [Improvement] allow my_id to be not new-line terminated HOT 1
- Message loss after reconnect HOT 11
- No direct bytes transmission support with new-line termination HOT 2
- Behavour of initial connect() HOT 3
- Asynchronous HTTPs requests HOT 2
- One message_id generator for all server clients HOT 1
- Server needs tx flow control HOT 4
- Wifi error due to indentation error HOT 6
- UDP support? HOT 1
- Connection not "ok" if server does not send anything except keepalive HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from micropython-iot.