Git Product home page Git Product logo

Comments (6)

peterhebert avatar peterhebert commented on August 24, 2024

Fixed by #2 - the theme now adds classes to the body tag for each active sidebar. The column no longer appears if the sidebar does not contain any widgets. Added new release 1.4.4. I've also pushed this release to WordPress theme directory, should appear shortly.

from simple-grey.

fengguangle avatar fengguangle commented on August 24, 2024

I already update to version 1.4.4.
But no any changes.
Any setting options?

update:
Maybe have some changes.
Now there is only one row when no secondary widget.

But the width of custom page is different from the width of post list page or post detail page.
The Row width is 1200 in sample-page, but the home page(post list) is 1500. both no widget.

I understand, in custom css,I add
.wrap { max-width: 60em; }
That can make every page having same width.

from simple-grey.

peterhebert avatar peterhebert commented on August 24, 2024

The default page template is set to have a maximum width of 60em, and show the secondary sidebar below the main content area. This was done to have optimum line length.

As this may be a bit confusing, I will move this styling to a separate page template (Single Column Narrow) in the next point release (1.5.0), and have the default page template work the same as the posts pages, with the secondary sidebar moving to the right at the breakpoint of 60em and wider. That way the default page keeps the same 1500 width as the rest of the post and archive templates.

from simple-grey.

fengguangle avatar fengguangle commented on August 24, 2024

I agree with your change, for a website, style unification is critical.
1500 width may not apply to some users. So you can add some custom setting options within the theme customization. Or these custom features are included in a paid version , maybe named Simple-Grey Pro. haha :)
In my opinion, this is a very good theme, simple, fast, beautiful, comfortable.
I like it, thank you for your work.

from simple-grey.

peterhebert avatar peterhebert commented on August 24, 2024

I have standardized on the 75em max width as the theme is designed to work well on mobile through larger (4k) desktop monitors. At larger breakpoints (1600px, 2400px, 3200px), the base text size also gets bumped up (1.25x, 1.5x, 2x) to deal with retina displays.

The new single column narrow template has been included in release 1.5.0.

As for a premium version of this theme, it is not something I have plans for at the moment. You can always customise the CSS via the LESS pre-processor files - available in this GitHub repo. You could fork this project as well to make your own custom version. I welcome pull requests.

from simple-grey.

fengguangle avatar fengguangle commented on August 24, 2024

I am not very good at web development, so I do not understand the real reasons for some of the problems, but I can submit issues.

from simple-grey.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.